[fix](compatibility) should enable windown funnel mode from 2.0 (apac…

…he#32284)
seawinde · Mar 16, 2024 · e4f0c60 · e4f0c60
1 parent 5887154
commit e4f0c60
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/be/src/agent/be_exec_version_manager.h b/be/src/agent/be_exec_version_manager.h
@@ -60,8 +60,9 @@ class BeExecVersionManager {
  *    e. add repeat_max_num in repeat function
  * 3: start from doris 2.0 (by some mistakes)
  *    a. aggregation function do not serialize bitmap to string.
+ *    b. support window funnel mode.
  * 4: start from doris 2.1
- *    a. support window funnel mode from 2.0
+ *    a. ignore this line, window funnel mode should be enabled from 2.0.
  *    b. array contains/position/countequal function return nullable in less situations.
  *    c. cleared old version of Version 2.
  *    d. unix_timestamp function support timestamp with float for datetimev2, and change nullable mode.

diff --git a/be/src/vec/aggregate_functions/aggregate_function_window_funnel.h b/be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
@@ -270,8 +270,8 @@ class AggregateFunctionWindowFunnel
 
     void create(AggregateDataPtr __restrict place) const override {
         auto data = new (place) WindowFunnelState<DateValueType, NativeType>();
-        /// support window funnel mode from 2.1. See `BeExecVersionManager::max_be_exec_version`
-        data->enable_mode = version >= USE_NEW_SERDE;
+        /// support window funnel mode from 2.0. See `BeExecVersionManager::max_be_exec_version`
+        data->enable_mode = version >= 3;
     }
 
     String get_name() const override { return "window_funnel"; }