Skip to content

Commit

Permalink
[fix](runtime filter) Fix unreasonable wrong status (apache#44545)
Browse files Browse the repository at this point in the history
Introduced by apache#43627 

Query could be finished when runtime filter was sent to a global runtime
filter merger. Here we should return `EOF` status instead of
`InvalidArgument`.
  • Loading branch information
Gabriel39 authored Nov 25, 2024
1 parent b978788 commit aa92038
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions be/src/runtime/fragment_mgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1292,8 +1292,8 @@ Status FragmentMgr::sync_filter_size(const PSyncFilterSizeRequest* request) {
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
query_ctx = q_ctx;
} else {
return Status::InvalidArgument(
"Sync filter size failed: Query context (query-id: {}) not found",
return Status::EndOfFile(
"Sync filter size failed: Query context (query-id: {}) already finished",
queryid.to_string());
}
}
Expand All @@ -1313,8 +1313,8 @@ Status FragmentMgr::merge_filter(const PMergeFilterRequest* request,
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
query_ctx = q_ctx;
} else {
return Status::InvalidArgument(
"Merge filter size failed: Query context (query-id: {}) not found",
return Status::EndOfFile(
"Merge filter size failed: Query context (query-id: {}) already finished",
queryid.to_string());
}
}
Expand Down

0 comments on commit aa92038

Please sign in to comment.