modify the comment

seawinde · Dec 26, 2023 · 8525ed2 · 8525ed2
1 parent 23fe84e
commit 8525ed2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PredicatePropagation.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PredicatePropagation.java
@@ -88,6 +88,9 @@ public ComparisonInferInfo(InferType inferType,
     public Set<Expression> infer(Set<Expression> predicates) {
         Set<Expression> inferred = Sets.newHashSet();
         for (Expression predicate : predicates) {
+            // if we support more infer predicate expression type, we should impl withInferred() method.
+            // And should add inferred props in withChildren() method just like ComparisonPredicate,
+            // and it's subclass, to mark the predicate is from infer.
             if (!(predicate instanceof ComparisonPredicate)) {
                 continue;
             }

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Expression.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Expression.java
@@ -242,7 +242,7 @@ public Expression withChildren(List<Expression> children) {
     }
 
     public Expression withInferred(boolean inferred) {
-        throw new RuntimeException();
+        throw new RuntimeException("current expression has not impl the withInferred method");
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -242,7 +242,7 @@ public Expression withChildren(List<Expression> children) { @@
         }
         public Expression withInferred(boolean inferred) {
-            throw new RuntimeException();
+            throw new RuntimeException("current expression has not impl the withInferred method");
         }
         /**
@@ Expand Down @@