Add some test

seawinde · Nov 26, 2023 · 000f7f7 · 000f7f7
1 parent c443db7
commit 000f7f7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/...-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PredicatesSplitter.java b/...-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PredicatesSplitter.java
@@ -36,6 +36,7 @@
 /**
  * Split the expression to equal, range and residual predicate.
  * Should instance when used.
+ * TODO support complex predicate split
  */
 public class PredicatesSplitter {
 
@@ -66,6 +67,8 @@ public Void visitComparisonPredicate(ComparisonPredicate comparisonPredicate, Ex
                 if (leftArgOnlyContainsColumnRef && rightArgOnlyContainsColumnRef) {
                     equalPredicates.add(comparisonPredicate);
                     return null;
+                } else {
+                    residualPredicates.add(comparisonPredicate);
                 }
             } else if ((leftArgOnlyContainsColumnRef && rightArg instanceof Literal)
                     || (rightArgOnlyContainsColumnRef && leftArg instanceof Literal)) {

diff --git a/...src/main/java/org/apache/doris/nereids/trees/plans/visitor/ExpressionLineageReplacer.java b/...src/main/java/org/apache/doris/nereids/trees/plans/visitor/ExpressionLineageReplacer.java
@@ -75,6 +75,7 @@ public Expression visitNamedExpression(NamedExpression namedExpression,
 
     /**
      * The Collector for target named expressions
+     * TODO Collect named expression by targetTypes, tableIdentifiers
      */
     public static class NamedExpressionCollector
             extends DefaultExpressionVisitor<Void, ExpressionReplaceContext> {

diff --git a/...-core/src/test/java/org/apache/doris/nereids/rules/expression/PredicatesSplitterTest.java b/...-core/src/test/java/org/apache/doris/nereids/rules/expression/PredicatesSplitterTest.java
@@ -45,6 +45,14 @@ public void testSplitPredicates() {
                 "a = b",
                 "a > 7 and 10 > d",
                 "c = d or a = 10");
+        assetEquals("a = b and c + d = e and a > 7 and 10 > d",
+                "a = b",
+                "a > 7 and 10 > d",
+                "c + d = e");
+        assetEquals("a = b and c + d = e or a > 7 and 10 > d",
+                "",
+                "",
+                "a = b and c + d = e or a > 7 and 10 > d");
     }
 
     private void assetEquals(String expression,
@@ -67,7 +75,7 @@ private void assetEquals(String expression,
             Expression rangeExpression = replaceUnboundSlot(PARSER.parseExpression(expectedRangeExpr), mem);
             Assertions.assertEquals(rangeExpression, splitPredicate.getRangePredicate());
         } else {
-            Assertions.assertNull(splitPredicate.getResidualPredicate());
+            Assertions.assertNull(splitPredicate.getRangePredicate());
         }
 
         if (!StringUtils.isEmpty(expectedResidualExpr)) {