List of Events #118
List of Events #118
Conversation
|
@andrewiggins and @crtr0 This pull request is ready for review. |
|
Thanks Lucas. Can you please attach screenshots of the pages that you've added or altered to this PR? |
home /I added a link to the past events (/events) list under the current events info.
/eventsThere is no major styling on this page and I wanted to chat with what you envisioned. I noticed most links still had default styling on the page so I left then as is.
/events/$idI copied pasta styles to display speaker images and talk info as well as I left sponsors on the page. I also displayed the event description but may remove it since it, for the most part, will just mention the price of the early bird. The other thought was just change the description in the data.json to whatever we want.
|
|
Looks good! Can you please figure out how to left-align the list of events so that it lines up with the heading? |
app/elements/event-sponsors.mjs
Outdated
| } | ||
| @media only screen and (min-width: 768px) { | ||
| :host { | ||
| display: flex; |
There was a problem hiding this comment.
The list of events looks a little funky on a desktop browser. It's not aligned with the title. Probably not a blocking issue, but is there an easy fix?
There was a problem hiding this comment.
whoops, Carter already mentioned this here: #118 (comment)
|
Last nitpick - can you please not display a future event (i.e. the Oct 2023 event) on the "Past Events" page? |
|
|
Yes, please fix the dates. Second Wednesday of the month for all of them should be correct (or close enough). |
|
Event dates are fixed in the json. @crtr0 |
There was a problem hiding this comment.
Hey @L-Steinmacher, thanks for doing this! We've long needed this page :) Left you some thoughts
Adding a list of past Seattle JS events that routes to the individual event page.