Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize headers on partial parse #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tgnottingham
Copy link

The main benefit of this is that it enables you to get the parsed headers from partial results when using uninitialized headers. Prior to this, on a partial result, the headers in a request or response would be replaced with the original slice passed when creating the request or response (typically an empty slice when using uninitialized headers), rather than the initialized portion of the uninitialized headers passed into the parse function call.

It also makes handling partial parse results more convenient in general since you can iterate over the headers in the request or response without having to manually determine the last element.

This is technically a breaking change, though it seems unlikely that any client would depend on the previous behavior in a way that the change would break their code.

The main benefit of this is that it enables you to get the parsed
headers from partial results when using uninitialized headers. Prior to
this, on a partial result, the headers in a request or response would be
replaced with the original slice passed when creating the request or
response (typically an empty slice when using uninitialized headers),
rather than the initialized portion of the uninitialized headers passed
into the parse function call.

It also makes handling partial parse results more convenient in general
since you can iterate over the headers in the request or response
without having to manually determine the last element.

This is technically a breaking change, though it seems unlikely that any
client would depend on the previous behavior in a way that the change
would break their code.
@tgnottingham
Copy link
Author

I realized that there is a use case where a client might have depended on the previous behavior -- repeatedly using the same Request/Response until the result is Complete. With this change, if a later parse input has more header fields than a previous input, it will result in a TooManyHeaders error because the previous partial parse shrunk the headers.

Of course, even without my change, Complete Requests/Responses can't be reused for the exact same reason. Still, I'm guessing the change in behavior in the Partial case is enough to dissuade accepting this PR. Bummer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant