Add python bindings for configurations #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #125 +/- ##
============================================
- Coverage 89.74% 89.73% -0.02%
============================================
Files 73 73
Lines 6991 7001 +10
============================================
+ Hits 6274 6282 +8
- Misses 717 719 +2
☔ View full report in Codecov by Sentry. |
vulder
requested changes
Sep 15, 2023
Comment on lines
+50
to
+51
| if os.path.exists('/lib/x86_64-linux-gnu/libz3.so'): | ||
| cmake_args.append('-DVARA_FEATURE_BUILD_Z3_SOLVER=False') |
There was a problem hiding this comment.
I'm not sure if this is a good way to determine if we should build the solver.
- the path is a system specific
- we might want to build the solver from scratch even for those system, as we depend on a very specific version of z3. (The debian 11 can cause problems)
Maybe we should keep building the solver as the default and give the user a option to disable that? Or, if it works for you, only you use the local one.
For some reason, this caused other configs to appear multiple times during enumeration.
This caused 2 issues: - either first config was skipped or getCurrentConfig would always point to the next configuration - getAllValidConfigurations or getNumberValidConfigurations produce incorrect results if called after any call to getNextConfiguration() The last point is an issue with the Solver API and this is a quick-fix for the Z3Solver implementation that returns an error in that case.
This implementation is quite hacky and requires a redesign of the Solver API to be fixed properly.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+76
to
+77
| auto FM = feature::loadFeatureModel( | ||
| getTestResource("test_msmr.xml")); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| auto FM = feature::loadFeatureModel( | |
| getTestResource("test_msmr.xml")); | |
| auto FM = feature::loadFeatureModel(getTestResource("test_msmr.xml")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.