-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.0 #212
Merged
Version 4.0 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the commit messsage data using the new read function and merge either nothing, the title or message and title into the commit.data of the proj.conf instance. See #180 Signed-off-by: Niklas Schneider <[email protected]>
Add the new attribute "commit.messages" to the project configuration class with options "none", "title" and "message" to make it possible to specify what exactly of the commit message data is to be merged to the commit data. See #180 Signed-off-by: Niklas Schneider <[email protected]>
Signed-off-by: Niklas Schneider <[email protected]>
Add two tests for testing the merge functionality for both full commit messages and titles only. Fix bug that merges message body instead of title when selecting option "title" See #180 Signed-off-by: Niklas Schneider <[email protected]>
Signed-off-by: Niklas Schneider <[email protected]>
Also exchange the merge attribute when merging data frames of commit messages from commit.id to hash. Signed-off-by: Niklas Schneider <[email protected]>
Signed-off-by: Niklas Schneider <[email protected]>
As commit.id was the first column of the data frame anyway, merging has not changed the order. But when using the hash column it is taken as the first colum of the resulting data frame. Change the order of the columns in order to not break anything that relies on the order. See #180 Signed-off-by: Niklas Schneider <[email protected]>
Follow the review suggestions of @clhunsen. See #180 Signed-off-by: Niklas Schneider <[email protected]>
Following the review of #193 Signed-off-by: Niklas Schneider <[email protected]>
Remove some empty lines and indent some lines. Also remove commit.message.data.unprocessed variable and use the commit.message.data variable from the beginning. Add column names beforehand in order to enable access without indices. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Create private function update.commit.message.data in util-data.R which handles the merge and change the location where it is called in set.commits. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Fix an error where the value of a variable that is defined in an if block is returned outside that if block. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Replaced a loop with a conversion from a list of vectors in a data frame and access its columns directly See #193 Signed-off-by: Niklas Schneider <[email protected]>
Move functions concerning reading commit messages and the constants used by them to a new section in util.read. Replace subset with proper indexing and minor comment fixes. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Also adapt 'update.commit.messages' to better match the implementation of similar methods. Add 'set.commit.messages' in order to be able to set the commit messages to NULL. See #193. Signed-off-by: Niklas Schneider <[email protected]>
Introduce new function 'format.commit.ids' in along with new section in util-read.R. Also put format "<commit-%s>" into a constant. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Take advice by @clhunsen to replace if else cascade for rearranging columns with better merge call. Also modify test-data tests regarding commit messages: Row names are no longer ignored. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Change order in 'README.md', 'util-conf.R' and 'util-data.R' Also fix table of contents in the readme. See #193 Signed-off-by: Niklas Schneider <[email protected]>
See #193 Signed-off-by: Niklas Schneider <[email protected]>
Add the package in 'install.R' and a description in the 'README.md'. Also rearrange the parameter descriptions of 'ProjectConf' to be sorted alphabetically. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Use the new data.table package to replace do.call with data.table::rbindlist which is faster in processing data.frames. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Signed-off-by: Niklas Schneider <[email protected]>
See #193 Signed-off-by: Niklas Schneider <[email protected]>
Remove hardcoded string formatting and replace it in tests for creating expected data using the new function 'format.commit.ids'. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Follow @clhunsen's advice to create commit message data with an lapply to avoid having a for-loop and an additional lapply call afterwards See #193 Signed-off-by: Niklas Schneider <[email protected]>
Add check for the ProjectConf attribute 'commit.messages' before calling 'update.commit.messages'. Also fix a few errors in comments as well as one if condition where the wrong attribute was checked. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Add the getter call to the 'additional.data' list. See #193 Signed-off-by: Niklas Schneider <[email protected]>
See #193 Signed-off-by: Niklas Schneider <[email protected]>
Add (empty) commit message data to all data split tests in 'tests-split.R'. Also sor the additional data sources alphabetically in the tests. See #193 Signed-off-by: Niklas Schneider <[email protected]>
Signed-off-by: Christian Hechtl <[email protected]>
Add new threshold calculation for network-based classifications and other small fixes Reviewed-by: Thomas Bock <[email protected]>
…tering functionality Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
…tests Signed-off-by: Johannes Hostert <[email protected]>
…source>.filtered to get.<datasource>, for commits/mails/issues. Remove reflective method invocations. Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
…<data> and <data>.unfiltered Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Also order the edge attributes when changing them to make a identical check possible on two differently ordered lists. Signed-off-by: Christian Hechtl <[email protected]> Committed-by: Johannes Hostert <[email protected]>
Signed-off-by: Johannes Hostert <[email protected]>
Read bot data and filter bots Reviewed-by: Thomas Bock <[email protected]> Reviewed-by: Christian Hechtl <[email protected]>
With #209 we changed the threshold calculation for network-based classifications. But the use of the new threshold was still the old one. So now change the classification using the new threshold so that all authors with a centrality value greater than the threshold are considered core. This is documented in #205. Signed-off-by: Christian Hechtl <[email protected]>
Signed-off-by: Christian Hechtl <[email protected]>
Fix bug in author classification Reviewed-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Christian Hechtl <[email protected]>
Fix inconsistencies in log statements Reviewed-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
We are ready for version 4.0 of As everything has already been reviewed, I will merge right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0
Announcement
coronet
now has a logo and a website: https://se-sic.github.io/coronet (Logo #167, PR Logo & Website #196)Added
commit.messages
inProjectConf
:none
,title
andmessages
(PR Add commit message merge functionality #193, 85b1d05, fdc414a, 43e1894)cleanup.commit.message.data
andcleanup.synchronicity.data
to remove commit hashes that are not any more present in the commit data from the commit message data or synchronicity data (PR Add commit message merge functionality #193, 98e83b0)metrics.is.smallworld
to the metrics module in order to unify checks for smallworldness (similar to scalefreeness) (PR Fixes in the metrics module #195, ce1f812)metrics.vertex.centralities
to metrics module in order to simplify getting a data frame containing author names and their respective centrality values (d3cd528, e7182e7)get.data.sources.from.relations
toutil-networks.R
which extracts the data sources of a network that were used when building it (PR Fixes in the metrics module #195, d1e4413)get.data.sources.from.relations
function (PR Fixes in the metrics module #195, add0c74)preprocess.issue.data
, which implements common issue data filtering operations. (fcf5cee, a566cae, 5ba6feb)get.issues.uncached
, which gets the issues filtered without poisoning or using the cache. (eb919fa)get.issues.unfiltered
to get the unfiltered issues so that these methods follow the naming scheme known from the respective methods for commits (b9dd94c, e05f344)RangeData
object (PR Enable to read data at every point in time #201, 7f9394f). Additionally, when changing the configuration parameters concerning additional data sources, the environment of aProjectData
object is no longer reset (PR Enable to read data at every point in time #201, eed45ac)commits.locked
,mails.locked
andissues.locked
toProjectConf
which, when set toTRUE
, prevent the respective getters from triggering the read of the data if it is not present yet (PR Enable to read data at every point in time #201, 3821677)Changed/Improved
get.<datasource>.unfiltered
, filtered data is acquired usingget.<datasource>
(edf19cf, e05f344)metrics.hub.degree
function. In the case of an empty network, a warning is being printed andNA
is returned (PR Fixes in the metrics module #195, 4b164be)ProjectData$get.artifacts
: Rename its single parameter todata.sources
and change the function so that it can extract the artifacts for multiple data sources at once. The default is still that only artifacts from the commit data are extracted. (PR Fixes in the metrics module #195, cf795f2, 70c05ec, 5a46ff4, fd767bb)NULL
to empty data frames and adapt functionget.cached.data.sources()
ofProjectData
which returns a vector of all data sources that are cached (including additional and filtered data sources) (PR Enable to read data at every point in time #201, aec898e, e55d088, 24c222a); additionally, introduce new functionis.data.source.cached()
inutil-data.R
that returns a logical vector indicating which of the given data sources are cached (PR Enable to read data at every point in time #201, b49cc5d, 491e70c, 24c222a)util-network-metrics.R
andutil.conf.R
(PR Fixes in the metrics module #195, f929248, de9988c, PR Fix wrong data path issue and emerging bugs #199, 059b286)ProjectData
(PR Enable to read data at every point in time #201, 52a3014, aec898e, de1bbfe)util-core-peripheral.R
by adding roxygen skeleton documentation to undocumented functions (issue Update core-peripheral module #70, PR Add new threshold calculation for network-based classifications and other small fixes #209, a3d5ca7, 6f737c8)$
notation to the bracket notation inutil-core-peripehral.R
(issue Update core-peripheral module #70, PR Add new threshold calculation for network-based classifications and other small fixes #209, 6f737c8).drone.yml
to enable running our CI pipelines on drone.io (PR Set up CI pipeline for drone.io #191, 1c5804b)NA
vectors or empty POSIXct vectors which are correctly added as of R version 4.1 (PR Necessary adjustments for the recently released R version 4.1 #203, 6b7fb36, 98c5671, 09d11ab)Fixed
commit_added
events are affected, that only happens for these. (issue When to do timestamp extraction for issue data? Before or after event filtering? #185, 627873c, 6ff585d)reset.environment()
of both theProjectData
andNetworkBuilder
class; they now reset all the data (PR Fix wrong data path issue and emerging bugs #199, de091a5, fc4c086)update.commit.message.data()
,update.pasta.data()
, andupdate.synchronicity.data()
: no warning is being printed anymore when being called by the corresponding cleanup function (PR Fix wrong data path issue and emerging bugs #199, e5c60a5)RangeData
objects was wrong in special cases. Introduce the (private) flagbuilt.from.range.data.read
that is set according to how the object has been created (splitting manually or reading codeface ranges) and calculating the data path accordingly (PR Fix wrong data path issue and emerging bugs #199, cce9527, 917bf64, 169c034). Also add tests for this new behaviour (PR Fix wrong data path issue and emerging bugs #199, ef5bac6, 3aa8e7d, d454e5a, 66ad127)ProjectConf
, instead create a copy (e82d056)plot.network
(03f986d)construct.ranges
when only one range has to bee constructed andsliding.window = TRUE
(000314b)reshape2
to the install script as this package is used in moduleutil-plot-evolution.R
for quite a while but never has been added to the list of packages to install (7bb4e7b)test-data.R
to use deep clones ofProjectData
objects (PR Add new threshold calculation for network-based classifications and other small fixes #209, d75373a)update.values()
function inutil-conf.R
to delete thevalue
field if the new value is equal to the default value as the comparison of two otherwise equalConf
objects fails without this (PR Add new threshold calculation for network-based classifications and other small fixes #209, d75373a)