Implements feature based perf instrumentation comparision #3542
reviewdog [mypy] report
reported by reviewdog 🐶
Findings (6)
varats/varats/experiments/vara/feature_perf_precision.py|165 col 32| error: Argument 2 to "init" of "MultiPatchReport" has incompatible type "type[PerfInfluenceTraceReportAggregate]"; expected "type[TEFReportAggregate]" [arg-type]
varats/varats/tables/feature_perf_precision.py|38 col 1| error: Function is missing a type annotation for one or more arguments [no-untyped-def]
varats/varats/tables/feature_perf_precision.py|47 col 14| error: "LinearSegmentedColormap" has no attribute "_segmentdata" [attr-defined]
varats/varats/tables/feature_perf_precision.py|57 col 5| error: Function is missing a type annotation for one or more arguments [no-untyped-def]
varats/varats/tables/feature_perf_precision.py|84 col 5| error: Function is missing a return type annotation [no-untyped-def]
varats/varats/tables/feature_perf_precision.py|357 col 57| error: Argument 2 to "cmap_map" has incompatible type "Colormap"; expected "LinearSegmentedColormap" [arg-type]
Filtered Findings (79)
varats-core/varats/experiment/steps/recompile.py|8 col 17| error: Class cannot subclass "ProjectStep" (has type "Any") [misc]
varats-core/varats/experiment/steps/patch.py|13 col 18| error: Class cannot subclass "ProjectStep" (has type "Any") [misc]
varats-core/varats/experiment/steps/patch.py|45 col 19| error: Class cannot subclass "ProjectStep" (has type "Any") [misc]
varats-core/varats/report/multi_patch_report.py|41 col 16| error: Incompatible return value type (got "Optional[ReportTy]", expected "ReportTy") [return-value]
varats/varats/plot/plot_utils.py|108 col 28| error: Incompatible default for argument "ax" (default has type "None", argument has type "SubplotBase") [assignment]
varats/varats/plot/plot_utils.py|108 col 28| note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
varats/varats/plot/plot_utils.py|108 col 28| note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
varats/varats/plot/plot_utils.py|114 col 10| error: Incompatible types in assignment (expression has type "Union[SubplotBase, Axes]", variable has type "SubplotBase") [assignment]
varats/varats/plot/plot_utils.py|116 col 5| error: "SubplotBase" has no attribute "annotate" [attr-defined]
varats/varats/plot/plot_utils.py|119 col 18| error: "SubplotBase" has no attribute "transAxes" [attr-defined]
varats/varats/plot/plot_utils.py|124 col 5| error: "SubplotBase" has no attribute "annotate" [attr-defined]
varats/varats/plot/plot_utils.py|127 col 18| error: "SubplotBase" has no attribute "transAxes" [attr-defined]
varats/varats/tools/driver_table.py|47 col 10| error: Argument 1 to "pass_context" has incompatible type "Callable[[Arg(Context, 'context'), KwArg(Any)], None]"; expected "Callable[[Context, KwArg(Any)], None]" [arg-type]
varats/varats/tools/driver_table.py|47 col 10| note: This is likely because "command_template" has named arguments: "context". Consider marking them positional-only
varats/varats/tools/driver_table.py|86 col 2| error: Argument 1 to "pass_context" has incompatible type "Callable[[Arg(Context, 'context'), KwArg(Any)], None]"; expected "Callable[[Context, KwArg(Any)], None]" [arg-type]
varats/varats/tools/driver_table.py|86 col 2| note: This is likely because "main" has named arguments: "context". Consider marking them positional-only
varats/varats/tools/driver_plot.py|47 col 10| error: Argument 1 to "pass_context" has incompatible type "Callable[[Arg(Context, 'context'), KwArg(Any)], None]"; expected "Callable[[Context, KwArg(Any)], None]" [arg-type]
varats/varats/tools/driver_plot.py|47 col 10| note: This is likely because "command_template" has named arguments: "context". Consider marking them positional-only
varats/varats/tools/driver_plot.py|86 col 2| error: Argument 1 to "pass_context" has incompatible type "Callable[[Arg(Context, 'context'), KwArg(Any)], None]"; expected "Callable[[Context, KwArg(Any)], None]" [arg-type]
varats/varats/tools/driver_plot.py|86 col 2| note: This is likely because "main" has named arguments: "context". Consider marking them positional-only
varats/varats/plots/paper_config_overview.py|221 col 25| error: Argument "facecolor" to "Patch" has incompatible type "ndarray[Any, dtype[floating[_64Bit]]]"; expected "Optional[Union[Union[tuple[float, float, float], str], Union[str, tuple[float, float, float, float], tuple[Union[tuple[float, float, float], str], float], tuple[tuple[float, float, float, float], float]]]]" [arg-type]
varats/varats/plots/paper_config_overview.py|222 col 25| error: Argument "facecolor" to "Patch" has incompatible type "ndarray[Any, dtype[floating[_64Bit]]]"; expected "Optional[Union[Union[tuple[float, float, float], str], Union[str, tuple[float, float, float, float], tuple[Union[tuple[float, float, float], str], float], tuple[tuple[float, float, float, float], float]]]]" [arg-type]
varats/varats/plots/paper_config_overview.py|223 col 25| error: Argument "facecolor" to "Patch" has incompatible type "ndarray[Any, dtype[floating[_64Bit]]]"; expected "Optional[Union[Union[tuple[float, float, float], str], Union[str, tuple[float, float, float, float], tuple[Union[tuple[float, float, float], str], float], tuple[tuple[float, float, float, float], float]]]]" [arg-type]
varats/varats/tools/driver_casestudy.py|395 col 10| error: Argument 1 to "pass_context" has incompatible type "Callable[[Arg(Context, 'context'), KwArg(Any)], None]"; expected "Callable[[Context, KwArg(Any)], None]" [arg-type]
varats/varats/tools/driver_casestudy.py|395 col 10| note: This is likely because "command_template" has named arguments: "context". Consider marking them positional-only
varats/varats/plots/commit_report_plots.py|8 col 1| error: Module "matplotlib.backends.backend_qt5agg" does not explicitly export attribute "FigureCanvasQTAgg" [attr-defined]
varats/varats/plots/commit_report_plots.py|31 col 23| error: Call to untyped function "FigureCanvasQTAgg" in typed context [no-untyped-call]
varats/varats/plots/commit_report_plots.py|56 col 9| error: Call to untyped function "draw" in typed context [no-untyped-call]
varats/varats/plots/blame_lorenz_curve.py|59 col 5| error: "SubplotBase" has no attribute "plot" [attr-defined]
varats/varats/plots/blame_lorenz_curve.py|73 col 5| error: "SubplotBase" has no attribute "plot" [attr-defined]
varats/varats/plots/blame_lorenz_curve.py|109 col 9| error: Argument 1 to "draw_code_churn" has incompatible type "SubplotBase"; expected "Axes" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|177 col 13| error: Argument 1 to "draw_interaction_lorenz_curve" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|181 col 13| error: Argument 1 to "draw_perfect_lorenz_curve" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|184 col 37| error: Argument 1 to "draw_interaction_code_churn" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|188 col 13| error: Argument 1 to "draw_interaction_lorenz_curve" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|192 col 13| error: Argument 1 to "draw_perfect_lorenz_curve" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|196 col 13| error: Argument 1 to "draw_interaction_code_churn" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|297 col 5| error: "SubplotBase" has no attribute "plot" [attr-defined]
varats/varats/plots/blame_lorenz_curve.py|347 col 5| error: "SubplotBase" has no attribute "plot" [attr-defined]
varats/varats/plots/blame_lorenz_curve.py|395 col 13| error: Argument 1 to "draw_gini_blame_over_time" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|399 col 13| error: Argument 1 to "draw_gini_blame_over_time" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|403 col 13| error: Argument 1 to "draw_gini_blame_over_time" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|407 col 13| error: Argument 1 to "draw_gini_churn_over_time" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|411 col 13| error: Argument 1 to "draw_gini_churn_over_time" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|415 col 13| error: Argument 1 to "draw_gini_churn_over_time" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_lorenz_curve.py|422 col 37| error: Argument 1 to "draw_interaction_code_churn" has incompatible type "Axes"; expected "SubplotBase" [arg-type]
varats/varats/plots/blame_diff_correlation_matrix.py|57 col 28| error: Incompatible default for argument "ax" (default has type "None", argument has type "SubplotBase") [assignment]
varats/varats/plots/blame_diff_correlation_matrix.py|57 col 28| note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
varats/varats/plots/blame_diff_correlation_matrix.py|57 col 28| note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
varats/varats/plots/blame_diff_correlation_matrix.py|63 col 10| error: Incompatible types in assignment (expression has type "Union[SubplotBase, Axes]", variable has type "SubplotBase") [assignment]
varats/varats/plots/blame_diff_correlation_matrix.py|70 col 11| error: "SubplotBase" has no attribute "twinx" [attr-defined]
varats/varats/plots/blame_diff_correlation_matrix.py|94 col 14| error: Argument 1 to "pad_axes" has incompatible type "SubplotBase"; expected "Axes" [arg-type]
varats/varats/plots/blame_diff_correlation_matrix.py|96 col 17| error: Argument 1 to "align_yaxis" has incompatible type "SubplotBase"; expected "Axes" [arg-type]
varats/varats/plots/blame_diff_correlation_matrix.py|124 col 28| error: Incompatible default for argument "ax" (default has type "None", argument has type "SubplotBase") [assignment]
varats/varats/plots/blame_diff_correlation_matrix.py|124 col 28| note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
varats/varats/plots/blame_diff_correlation_matrix.py|124 col 28| note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
varats/varats/plots/blame_diff_correlation_matrix.py|128 col 10| error: Incompatible types in assignment (expression has type "Union[SubplotBase, Axes]", variable has type "SubplotBase") [assignment]
varats/varats/plots/blame_diff_correlation_matrix.py|133 col 11| error: "SubplotBase" has no attribute "twinx" [attr-defined]
varats/varats/plots/blame_diff_correlation_matrix.py|136 col 14| error: Argument 1 to "pad_axes" has incompatible type "SubplotBase"; expected "Axes" [arg-type]
varats/varats/plots/blame_diff_correlation_matrix.py|138 col 17| error: Argument 1 to "align_yaxis" has incompatible type "SubplotBase"; expected "Axes" [arg-type]
varats/varats/plots/blame_verifier_report_plots.py|226 col 5| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "set_xlim" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|226 col 5| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "set_xlim" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|227 col 5| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "grid" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|227 col 5| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "grid" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|228 col 5| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "set_xlabel" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|228 col 5| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "set_xlabel" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|229 col 5| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "set_ylabel" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|229 col 5| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "set_ylabel" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|230 col 5| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "yaxis" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|230 col 5| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "yaxis" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|247 col 9| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "plot" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|247 col 9| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "plot" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|254 col 5| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "title" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|254 col 5| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "title" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|257 col 9| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "get_xticklabels" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|257 col 9| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "get_xticklabels" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|260 col 14| error: Item "ndarray[Any, Any]" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "legend" [union-attr]
varats/varats/plots/blame_verifier_report_plots.py|260 col 14| error: Item "SubplotBase" of "Union[ndarray[Any, Any], SubplotBase, Axes]" has no attribute "legend" [union-attr]
varats/varats/tools/driver_graph_view.py|35 col 17| error: Redundant cast to "StandardButtons" [redundant-cast]
Annotations
Check failure on line 165 in varats/varats/experiments/vara/feature_perf_precision.py
github-actions / mypy
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L165
error: Argument 2 to "__init__" of "MultiPatchReport" has incompatible type "type[PerfInfluenceTraceReportAggregate]"; expected "type[TEFReportAggregate]" [arg-type]
Raw output
varats/varats/experiments/vara/feature_perf_precision.py:165:32: error: Argument 2 to "__init__" of "MultiPatchReport" has incompatible type "type[PerfInfluenceTraceReportAggregate]"; expected "type[TEFReportAggregate]" [arg-type]
Check failure on line 38 in varats/varats/tables/feature_perf_precision.py
github-actions / mypy
[mypy] varats/varats/tables/feature_perf_precision.py#L38
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
Raw output
varats/varats/tables/feature_perf_precision.py:38:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
Check failure on line 47 in varats/varats/tables/feature_perf_precision.py
github-actions / mypy
[mypy] varats/varats/tables/feature_perf_precision.py#L47
error: "LinearSegmentedColormap" has no attribute "_segmentdata" [attr-defined]
Raw output
varats/varats/tables/feature_perf_precision.py:47:14: error: "LinearSegmentedColormap" has no attribute "_segmentdata" [attr-defined]
Check failure on line 57 in varats/varats/tables/feature_perf_precision.py
github-actions / mypy
[mypy] varats/varats/tables/feature_perf_precision.py#L57
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
Raw output
varats/varats/tables/feature_perf_precision.py:57:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
Check failure on line 84 in varats/varats/tables/feature_perf_precision.py
github-actions / mypy
[mypy] varats/varats/tables/feature_perf_precision.py#L84
error: Function is missing a return type annotation [no-untyped-def]
Raw output
varats/varats/tables/feature_perf_precision.py:84:5: error: Function is missing a return type annotation [no-untyped-def]
Check failure on line 357 in varats/varats/tables/feature_perf_precision.py
github-actions / mypy
[mypy] varats/varats/tables/feature_perf_precision.py#L357
error: Argument 2 to "cmap_map" has incompatible type "Colormap"; expected "LinearSegmentedColormap" [arg-type]
Raw output
varats/varats/tables/feature_perf_precision.py:357:57: error: Argument 2 to "cmap_map" has incompatible type "Colormap"; expected "LinearSegmentedColormap" [arg-type]