Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a BC file extension for Architecture, a bare-bones MDReport, an ArchitectureAnalysis experiment and "SynthSAWholeProgram" as a project #878
base: vara-dev
Are you sure you want to change the base?
Adds a BC file extension for Architecture, a bare-bones MDReport, an ArchitectureAnalysis experiment and "SynthSAWholeProgram" as a project #878
Changes from 2 commits
1e79e51
2e3571e
d6b90a1
ca641e2
6fe417a
6e35a8f
773f1bf
5384014
17cc720
56db4e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 11 in varats/varats/data/reports/md_report.py
GitHub Actions / pylint
[pylint] varats/varats/data/reports/md_report.py#L11 <511>
Raw output
Check warning on line 8 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L8 <611>
Raw output
Check failure on line 40 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L40 <116>
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mixed two things here: clang options and opt options.
In this analysis step, you want to produce a report by running a certain VaRA analysis.
This works similar to the
BlameReportGeneration
step and requiresopt
.The flags
"-O0", "-g0", "-fvara-GB", "-fvara-arch"
are all compiler flags which have to be passed toclang
.You have to set them before you add the
Compile
step (see comment below).As far as
opt
parameters go, you have to pass--enable-new-pm=0
,f"-vara-report-outfile={result_file}"
and an option that enables the analysis pass. However, you have to implement that pass on the VaRA side first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we already discussed how to go about implementing the pass on VaRA’s side? Or shall I look into this myself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have briefly talked about how that works in general, but no details yet.
You can take a look at existing passes to figure out how a pass for creating an
ArchitectureReport
could look like, e.g.,BlameReportCreatorPass
invara/Report/BlameReport.h
.Check failure on line 57 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / mypy
[mypy] varats/varats/experiments/vara/architecture_report_experiment.py#L57
Raw output
Check failure on line 57 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L57 <602>
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import this from
wllvm.py
. Same goes for theBCFileExtensions
.Check failure on line 59 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / mypy
[mypy] varats/varats/experiments/vara/architecture_report_experiment.py#L59
Raw output
Check failure on line 59 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L59 <602>
Raw output
Check failure on line 60 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / mypy
[mypy] varats/varats/experiments/vara/architecture_report_experiment.py#L60
Raw output
Check failure on line 60 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L60 <602>
Raw output
Check failure on line 65 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / mypy
[mypy] varats/varats/experiments/vara/architecture_report_experiment.py#L65
Raw output
Check failure on line 65 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L65 <602>
Raw output
Check failure on line 106 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / mypy
[mypy] varats/varats/experiments/vara/architecture_report_experiment.py#L106
Raw output
Check failure on line 106 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L106 <602>
Raw output
Check failure on line 112 in varats/varats/experiments/vara/architecture_report_experiment.py
GitHub Actions / pylint
[pylint] varats/varats/experiments/vara/architecture_report_experiment.py#L112 <305>
Raw output
Check warning on line 9 in varats/varats/projects/cpp_projects/featureperfcscollection.py
GitHub Actions / pylint
[pylint] varats/varats/projects/cpp_projects/featureperfcscollection.py#L9 <611>
Raw output
Check warning on line 9 in varats/varats/projects/cpp_projects/featureperfcscollection.py
GitHub Actions / pylint
[pylint] varats/varats/projects/cpp_projects/featureperfcscollection.py#L9 <611>
Raw output
Check warning on line 47 in varats/varats/projects/cpp_projects/featureperfcscollection.py
GitHub Actions / pylint
[pylint] varats/varats/projects/cpp_projects/featureperfcscollection.py#L47 <511>
Raw output