Add alternative Picosat Project #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #872 +/- ##
============================================
- Coverage 66.54% 66.49% -0.06%
============================================
Files 344 344
Lines 27891 27935 +44
============================================
+ Hits 18561 18575 +14
- Misses 9330 9360 +30 ☔ View full report in Codecov by Sentry. |
vulder
approved these changes
Feb 10, 2024
| @@ -191,19 +191,19 @@ def get_release_revisions( | |||
| if re.match(release_regex, tag)] | |||
|
|
|||
|
|
|||
| class PicoSATVaRA(VProject, ReleaseProviderHook): | |||
| class PicoSATLT(VProject, ReleaseProviderHook): | |||
There was a problem hiding this comment.
For what does the LT stand?
There was a problem hiding this comment.
My initial thought was Load Time - I wanted to pick a more speaking addition to the normal Picosat for distinction that just VaRA, but in hindsight the LT itself is also not really more helpful.
There was a problem hiding this comment.
The idea is good, maybe just call it that PicoSATLoadTime
There was a problem hiding this comment.
Done.
Branch should be ready for a merge into vara-dev now
LuAbelt
commented
Feb 19, 2024
vulder
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fork for Picosat that does not rely on field sensitivity as much