Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes threshold handling for feature experiments #853

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

vulder
Copy link
Contributor

@vulder vulder commented Oct 20, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (92903b8) 68.45% compared to head (c82ed3a) 68.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##           vara-dev     #853      +/-   ##
============================================
- Coverage     68.45%   68.45%   -0.01%     
============================================
  Files           335      335              
  Lines         26127    26130       +3     
============================================
+ Hits          17885    17887       +2     
- Misses         8242     8243       +1     
Files Coverage Δ
...rats/varats/experiments/vara/feature_experiment.py 44.37% <50.00%> (+0.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vulder vulder requested review from boehmseb and LuAbelt October 20, 2023 12:26
@vulder vulder merged commit 19212e1 into vara-dev Oct 23, 2023
8 of 10 checks passed
@vulder vulder deleted the f-FixThresholdhandling branch October 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants