Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds token for runtime config params for workload commands. #844

Merged
merged 11 commits into from
Oct 12, 2023

Conversation

boehmseb
Copy link
Member

@boehmseb boehmseb commented Oct 7, 2023

No description provided.

@boehmseb boehmseb requested a review from vulder October 7, 2023 18:13
Copy link
Contributor

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works and LGTM

we need the BB release + update, afterwards we can merge this

@boehmseb boehmseb marked this pull request as ready for review October 12, 2023 08:21
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (ccdd7fc) 68.41% compared to head (17691e9) 68.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##           vara-dev     #844      +/-   ##
============================================
+ Coverage     68.41%   68.42%   +0.01%     
============================================
  Files           335      335              
  Lines         26014    26055      +41     
============================================
+ Hits          17798    17829      +31     
- Misses         8216     8226      +10     
Files Coverage Δ
tests/experiment/test_workload_util.py 100.00% <100.00%> (ø)
tests/utils/test_experiment_util.py 96.91% <100.00%> (+0.01%) ⬆️
varats-core/varats/experiment/experiment_util.py 68.30% <100.00%> (-3.79%) ⬇️
varats/varats/experiments/base/just_compile.py 56.41% <100.00%> (+1.14%) ⬆️
...rats/varats/experiments/vara/feature_experiment.py 43.91% <100.00%> (+0.38%) ⬆️
.../projects/perf_tests/feature_perf_cs_collection.py 65.94% <100.00%> (+0.54%) ⬆️
varats-core/varats/experiment/workload_util.py 91.17% <87.50%> (-0.63%) ⬇️
varats-core/varats/utils/config.py 93.02% <91.89%> (-6.98%) ⬇️
varats-core/varats/project/varats_command.py 81.63% <60.86%> (-15.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vulder vulder merged commit 593ab64 into vara-dev Oct 12, 2023
10 checks passed
@vulder vulder deleted the f-RuntimeConfigOptionsToken branch October 12, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants