Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Patch Provider pulling in parallel #835

Merged
merged 9 commits into from
Sep 22, 2023
Merged

Fix Patch Provider pulling in parallel #835

merged 9 commits into from
Sep 22, 2023

Conversation

LuAbelt
Copy link
Contributor

@LuAbelt LuAbelt commented Sep 12, 2023 •
edited
Loading

Adds some safeguards to avoid pulling concurrently when running experiments on the cluster

Fixes https://github.com/se-sic/VaRA/issues/1038

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (b344eb4) 68.25% compared to head (30b029b) 68.27%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           vara-dev     #835      +/-   ##
============================================
+ Coverage     68.25%   68.27%   +0.02%     
============================================
  Files           333      333              
  Lines         25719    25738      +19     
============================================
+ Hits          17554    17573      +19     
  Misses         8165     8165
Files Changed Coverage Δ
...arats-core/varats/provider/patch/patch_provider.py 88.11% <100.00%> (+0.61%) ⬆️
varats-core/varats/utils/filesystem_util.py 94.11% <100.00%> (+14.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuAbelt LuAbelt marked this pull request as ready for review September 13, 2023 12:30
@LuAbelt LuAbelt requested review from vulder and boehmseb September 13, 2023 12:30
vulder
vulder approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, following the docs, this looks fine.

varats-core/varats/provider/patch/patch_provider.py Outdated Show resolved Hide resolved
@vulder vulder requested a review from boehmseb September 14, 2023 14:17
@vulder vulder merged commit af451e3 into vara-dev Sep 22, 2023
10 checks passed
@vulder vulder deleted the f-FixParallelPatchProvider branch September 22, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boehmseb boehmseb boehmseb approved these changes

@vulder vulder vulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuAbelt @vulder @boehmseb