Skip to content

Commit

Permalink
Rewords docs
Browse files Browse the repository at this point in the history
  • Loading branch information
vulder committed Aug 19, 2024
1 parent 881be9e commit 300a313
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions varats-core/varats/report/hot_functions_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ def top_n_functions(self, limit=10) -> tp.List[XRayFunctionWrapper]:
def hot_functions(self, threshold=2) -> tp.List[XRayFunctionWrapper]:

Check failure on line 36 in varats-core/varats/report/hot_functions_report.py

View workflow job for this annotation

GitHub Actions / reviewdog

varats-core/varats/report/hot_functions_report.py#L36

error: Function is missing a type annotation for one or more arguments [no-untyped-def]
Raw output
varats-core/varats/report/hot_functions_report.py:36:5: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
"""
Args:
threshold: min percentage a function needs as self time to count as hot
threshold: min percentage a function needs as total
time to count as hot
"""
if threshold < 0 or threshold > 100:
raise ValueError(
Expand Down Expand Up @@ -87,7 +88,8 @@ def hot_functions_per_workload(
) -> tp.Dict[str, tp.List[XRayFunctionWrapper]]:
"""
Args:
threshold: min percentage a function needs as self time to count as hot
threshold: min percentage a function needs as
total time to count as hot
"""
res: tp.Dict[str, tp.List[XRayFunctionWrapper]] = {}
for wl_name in self.workload_names():
Expand Down

0 comments on commit 300a313

Please sign in to comment.