GaussianCopula get_learned_distributions crashes if nothing was learned

[R-Palazzo]

CU-86b2w3hf2
Resolve #2297

[sdv-team]

Task linked: CU-86b2w3hf2 SDV - GaussianCopula get_learned_distributions crashes if nothing was learned #2297

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (7384de0) to head (a36d7b5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2339      +/-   ##
==========================================
+ Coverage   98.57%   98.58%   +0.01%     
==========================================
  Files          58       58              
  Lines        6095     6099       +4     
==========================================
+ Hits         6008     6013       +5     
+ Misses         87       86       -1     

Flag	Coverage Δ
integration	82.14% <20.00%> (-0.03%)	⬇️
unit	97.42% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lajohn4747]

LGTM

[pvk-developer]

I think that this is the more future proof version, reason being that if we update self._model to be initialized earlier, but to_dict is empty, we will return the empty {} otherwise it will crash when accessing parameters['columns'] on an empty dict:

Suggested change

	if self._model is None:
	return {}
	if not hasattr(self._model, 'to_dict') or not self._model.to_dict():
	return {}