Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning generated in SDV: Synthesizer Sequences (PAR) demo #2319

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix warning generated in SDV: Synthesizer Sequences (PAR) demo #2319

merged 1 commit into from
Dec 12, 2024

Conversation

fealho
Copy link
Member

@fealho fealho commented Dec 11, 2024

CU-86b2u95uk, Resolve #2286.

@sdv-team
Copy link
Contributor

Task linked: CU-86b2u95uk SDV - Pandas FutureWarning: The behavior of DataFrame concatenation with empty or all-NA entries is deprecated... #2286

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (faeef89) to head (8ca79c8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2319   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          58       58           
  Lines        6078     6078           
=======================================
  Hits         5992     5992           
  Misses         86       86
Flag Coverage Δ
integration 82.24% <100.00%> (ø)
unit 97.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review December 12, 2024 13:28
@fealho fealho requested a review from a team as a code owner December 12, 2024 13:28
@fealho fealho requested review from frances-h and removed request for a team December 12, 2024 13:28
@fealho fealho requested a review from R-Palazzo December 12, 2024 13:28
R-Palazzo
R-Palazzo approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Can you rename the PR title with the one of the issue?

@fealho fealho merged commit 47bc8d4 into main Dec 12, 2024
78 checks passed
@fealho fealho deleted the issue-2286-par-demo branch December 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Palazzo R-Palazzo R-Palazzo approved these changes

@frances-h frances-h frances-h approved these changes

Assignees

@fealho fealho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pandas FutureWarning: The behavior of DataFrame concatenation with empty or all-NA entries is deprecated...
4 participants
@fealho @sdv-team @frances-h @R-Palazzo