Issue 2130 metadata for evaluation #2149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tadata_over_multi
…tadata_over_multi
Base automatically changed from
issue_2129_metadata_over_multi
to
issue_2128_use_metadata_over_single
August 1, 2024 14:55
pvk-developer
requested review from
gsheni
and removed request for
a team,
frances-h and
pvk-developer
amontanez24
reviewed
Aug 2, 2024
| if isinstance(metadata, SingleTableMetadata): | ||
| self.metadata = Metadata().load_from_dict(metadata.to_dict()) | ||
| warnings.warn(DEPRECATION_MSG, FutureWarning) | ||
| self.metadata = Metadata()._convert_to_unified_metadata(metadata) |
There was a problem hiding this comment.
I think you need to rebase this. We're not converting to unified metadata here anymore
There was a problem hiding this comment.
I think we need to change the base of this, this is going to the 2128 branch but I think it has to go to feature/metadata 🤦🏻♂️
| if len(metadata.tables) > 1: | ||
| raise ValueError('Only a single table is allowed in metadata.') | ||
|
|
||
| metadata_dict = next(iter(metadata.tables.values())).to_dict() |
There was a problem hiding this comment.
In the case where it is the old metadata, we convert it to the new one by converting to a cit, and then loading from that. Then we go back to a dict here. Maybe we should just convert to a dict and raise the warning instead of converting back and forth
pvk-developer
changed the base branch from
issue_2128_use_metadata_over_single
to
feature/metadata
|
Closing this pull request as we went with a direction: #2174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2130
CU-86b19awxc
Make the evaluation methods work with metadata for both multi and single table methods:
sdv.evaluation.single_table.evaluate_quality
sdv.evaluation.single_table.run_diagnostic
sdv.evaluation.single_table.get_column_plot
sdv.evaluation.single_table.get_column_pair_plot
sdv.evaluation.multi_table.evaluate_quality
sdv.evaluation.multi_table.run_diagnostic
sdv.evaluation.multi_table.get_column_plot
sdv.evaluation.multi_table.get_column_pair_plot
sdv.evaluation.multi_table.get_cardinality_plot