Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out caching pip #2107

Closed
wants to merge 13 commits into from
Closed

Try out caching pip #2107

Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
55f6952
Try out caching pip
lajohn4747 Jul 3, 2024
8cdbf95
Caching pip on min test
lajohn4747 Jul 8, 2024
79bc519
Add log
lajohn4747 Jul 8, 2024
500bdf8
Add pip cache
lajohn4747 Jul 8, 2024
59666da
Merge branch 'main' into issue_2015_cache_tests
lajohn4747 Jul 10, 2024
d4736b8
Only cache windows
lajohn4747 Jul 10, 2024
341311f
Add back python-version
lajohn4747 Jul 10, 2024
f3a0f3c
Caching just windows
lajohn4747 Jul 10, 2024
737940b
Running it again
lajohn4747 Jul 10, 2024
1fc740a
Running it again
lajohn4747 Jul 10, 2024
c275d2b
Add call to pip install --no-dependencies
lajohn4747 Jul 10, 2024
2b38432
Add call to pip install --no-dependencies add invoke
lajohn4747 Jul 10, 2024
69c4ef8
revert --no-dependencies
lajohn4747 Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/minimum.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,19 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Cache pip on windows
id: cache-pip
if: runner.os == 'Windows'
uses: actions/cache@v3
with:
path: C:\Users\runneradmin\AppData\Local\pip\Cache
key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ hashFiles('**/pyproject.toml') }}
restore-keys: |
${{ runner.os }}-pip-${{ matrix.python-version }}-
- name: Check cache hit
if: runner.os == 'Windows'
run: |
echo "Cache hit status: ${{ steps.cache-pip.outputs.cache-hit }}"
- name: Install dependencies
run: |
Comment on lines 40 to 41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the cache to determine how to install dependencies:

Suggested change
- name: Install dependencies
run: |
- name: Install SDV (cache has not changed)
if: steps.cache-pip.outputs.cache-hit == 'true'
run: |
python -m pip install --no-dependencies .
- name: Install SDV and dependencies (cache has changed)
if: steps.cache-pip.outputs.cache-hit != 'true'
run: |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot call the force command --no-dependencies, as that command ignores installing dependencies altogether (Job example).

Pip looks into the cache location path and will directly install those files rather than re-download them so we don't need to have separate steps. Example here: we can see it using the cache and cut down the time for windows installation by not downloading. (~2-3 mins saved)

python -m pip install --upgrade pip
Expand Down
Loading