Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error if sequence_index is numerical #2080

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #2079
CU-86b0y3zdj

Ensure that if no transformer is assigned to sequence index, then do not error out.

@lajohn4747 lajohn4747 requested a review from a team as a code owner June 19, 2024 15:44
@sdv-team
Copy link
Contributor

Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an integration test as well?

@lajohn4747 lajohn4747 requested a review from frances-h June 20, 2024 15:14
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lajohn4747 lajohn4747 merged commit 486519d into main Jun 20, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_2079_handle_numerical_seq_index branch June 20, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PARSynthesizer errors during fit if sequence_index is numerical sdtype
4 participants