Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff for linting, remove flake8, remove isort, remove pylint #2069

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 14, 2024

CU-86azdvty7

@gsheni gsheni requested a review from amontanez24 June 14, 2024 20:18
@gsheni gsheni self-assigned this Jun 14, 2024
@sdv-team
Copy link
Contributor

@gsheni gsheni marked this pull request as ready for review June 14, 2024 20:19
@gsheni gsheni requested a review from a team as a code owner June 14, 2024 20:19
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I really like this Ruff addition, and as you mentioned and we have seen it, its very fast! 💯


[tool.ruff]
preview = true
line-length = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that our other libraries with Ruff use this line-length, so I'm fine with increasing it. I'm just curious if there's a new industry standard.

Fun fact: The pep-8 standard was 72-79. However this has been the most 'overwritten' rule.

@gsheni gsheni merged commit 407114c into main Jun 17, 2024
39 checks passed
@gsheni gsheni deleted the add_ruff branch June 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to using ruff for Python linting and code formatting
3 participants