Update the logger settings #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
requested review from
gsheni and
lajohn4747
and removed request for
a team
amontanez24
approved these changes
May 3, 2024
|
Task linked: CU-86b0ah0kh Update SDV Public Logger |
gsheni
approved these changes
May 3, 2024
|
Why are the unit/integration tests failing? |
It's unrelated and should be fixed by #1982 |
pvk-developer
force-pushed
the
issue-update-logger-to-not-log-on-public
branch
from
0da7ec1 to
a03919a
Compare
lajohn4747
approved these changes
May 6, 2024
pvk-developer
force-pushed
the
issue-update-logger-to-not-log-on-public
branch
from
e432bc6 to
4e815d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @amontanez24 , we would like to set the default config to None and not log the public usage.
This will be changed in enterprise.
CU-86b0ah0kh