Add ExcelHandler #1962
Merged
Add ExcelHandler #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86b05t4z0 SDV - Add ExcelHandler #1950 |
pvk-developer
requested review from
amontanez24 and
R-Palazzo
and removed request for
a team
pvk-developer
force-pushed
the
issue-1949-add-csvhandler
branch
from
be88f8f to
b01c582
Compare
pvk-developer
force-pushed
the
issue-1950-add-excelhandler
branch
from
f08f723 to
3318b12
Compare
R-Palazzo
reviewed
Apr 29, 2024
|
|
||
| @patch('sdv.io.local.local.pd') | ||
| def test_write(self, mock_pd): | ||
| # Setup |
sdv/io/local/local.py
Outdated
| """A class for handling Excel files.""" | ||
|
|
||
| def read(self, file_path, sheet_names=None): | ||
| """Read data from Excel files and returns it along with metadata. |
sdv/io/local/local.py
Outdated
| sheet_names = xl_file.sheet_names | ||
|
|
||
| for sheet_name in sheet_names: | ||
| data[sheet_name] = pd.read_excel( |
There was a problem hiding this comment.
Should we add a check that the sheet_name exists in the file_path here? Or it's ok to let pandas raise an error
amontanez24
requested changes
Apr 29, 2024
pyproject.toml
Outdated
Comment on lines
42
to
43
| 'xlsxwriter>=3.1.0', | ||
| 'openpyxl>=3.1.0' |
There was a problem hiding this comment.
After speaking with @npatki I think we should make these optional dependencies. I would also just refer to pandas' dependencies instead of maintaining this ourselves. Something like
[project.optional-dependencies]
excel_handler = [
'pandas[excel]'
]
pvk-developer
force-pushed
the
issue-1950-add-excelhandler
branch
from
3318b12 to
ab7585b
Compare
R-Palazzo
approved these changes
May 1, 2024
amontanez24
reviewed
May 1, 2024
amontanez24
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1950
CU-86b05t4z0