Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata isn't validating sdtypes in a column relationship (public SDV only) #1889

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

R-Palazzo
Copy link
Contributor

CU-86az9j5en
Resolve #1781

@R-Palazzo R-Palazzo requested review from amontanez24 and fealho April 4, 2024 09:33
@R-Palazzo R-Palazzo requested a review from a team as a code owner April 4, 2024 09:33
@sdv-team
Copy link
Contributor

sdv-team commented Apr 4, 2024

@R-Palazzo R-Palazzo removed the request for review from a team April 4, 2024 09:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (6f1120c) to head (f29d095).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
- Coverage   97.46%   97.45%   -0.02%     
==========================================
  Files          51       50       -1     
  Lines        4978     4949      -29     
==========================================
- Hits         4852     4823      -29     
  Misses        126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came together quite nicely imo

tests/test_tasks.py Show resolved Hide resolved
@R-Palazzo R-Palazzo force-pushed the issue-1781-metadata-validation-column-relationship branch from 3542ab5 to 300f045 Compare April 5, 2024 15:13
@R-Palazzo R-Palazzo force-pushed the issue-1781-metadata-validation-column-relationship branch from 300f045 to f29d095 Compare April 5, 2024 15:15
@R-Palazzo R-Palazzo merged commit 2edb56b into main Apr 5, 2024
37 checks passed
@R-Palazzo R-Palazzo deleted the issue-1781-metadata-validation-column-relationship branch April 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata isn't validating sdtypes in a column relationship (public SDV only)
5 participants