-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise a VersionError
when re-fitting a synthesizer that was created on a previous SDV version
#1886
Raise a VersionError
when re-fitting a synthesizer that was created on a previous SDV version
#1886
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
==========================================
- Coverage 97.51% 97.47% -0.05%
==========================================
Files 51 51
Lines 5119 4985 -134
==========================================
- Hits 4992 4859 -133
+ Misses 127 126 -1 ☔ View full report in Codecov by Sentry. |
VersionError
when re-fitting a synthesizer that was created on a previous SDV version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@amontanez24, @npatki The current solution will not be applied to DayZ. When updating DayZ, we may want to fix this as well.
e792bb2
to
bc431b9
Compare
Bear in mind that |
bc431b9
to
1980b4e
Compare
Resolves #1838
CU-86azkp7m4