Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Numpy 1.25+ #1623

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Support Numpy 1.25+ #1623

merged 4 commits into from
Oct 10, 2023

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Oct 10, 2023

Resolve #1501

A few tests have hardcoded answers that fail on some CI environments due to the beta distribution fit changing slightly with newer Numpy versions. These tests were changed to use Truncated Gaussian by default and the expected results updated accordingly.

@rwedge rwedge requested a review from a team as a code owner October 10, 2023 14:30
@rwedge rwedge requested review from R-Palazzo and amontanez24 and removed request for a team October 10, 2023 14:30
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwedge rwedge merged commit 626b4d3 into main Oct 10, 2023
74 checks passed
@rwedge rwedge deleted the issue-1501-numpy-capped-below-2 branch October 10, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate how to get numpy >1.25 to pass
3 participants