Resolve pomegranate import issues #701
Open
+30
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 94.44% 94.93% +0.48%
==========================================
Files 106 106
Lines 4103 4103
==========================================
+ Hits 3875 3895 +20
+ Misses 228 208 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rwedge
commented
Jan 3, 2025
Comment on lines
+87
to
+89
| pomegranate_deps = ' '.join(minimum_pomegranate_versions) | ||
| c.run(f'python -m pip install {install_deps}') | ||
| c.run(f'python -m pip install --force-reinstall --no-cache-dir {pomegranate_deps}') |
There was a problem hiding this comment.
perhaps the pomegranate logic should only be run if minimum_pomegranate_versions isn't empty
frances-h
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #630 by switching to pomegranate 0.15 and updating the
BNLikelihoodandBNLogLikelihoodmetrics to prompt the user to installpomegranateviapip install sdmetrics[pomegranate]instead ofpip install pomegranate.pip install pomegranatewas installing pomegranate version 1.x which breaks the API we use, as seen in #642.