Push results to the sky #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #50. It adds a new button to the Results page that lets users push the results table to the Sky Viewer. The sky viewer has been re-worked a bit since the initial loading of AladinLite was happening concurrently or after the push of data to the viewer. The aladin-lite viewer is now in an async function that returns a promise which is run
onMounted, and the target data load is delayed a bit until aladin finishes initializing.It also bumps the pinia-persist plugin to v4, which now allows to explicitly omit certain store keys from being persisted, and/or only persisting explicit paths.