Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carton/tools.py: add comment #452

Merged
merged 2 commits into from
Jul 3, 2024
Merged

carton/tools.py: add comment #452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5fe339
carton/tools.py: add comment
astronomygupta Jul 3, 2024
3b4940e
carton/tools.py: add comment
astronomygupta Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion python/target_selection/cartons/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,22 @@ def build_query(self, version_id, query_region=None):
peewee.Value(0).alias('value'))
.distinct(Catalog.catalogid))

# The above clause .distinct(Catalog.catalogid)) is
# part of below queries like
# query_gaia_dr3, query_gaia_dr2 etc. via query_common.
# Note that the DISTINCT clause applies to
# each of query_gaia_dr3, query_gaia_dr2 etc.
# However, it does not apply to the UNION of these queries.
# Hence, if the manual carton input fits file
# contains multiple types of IDs
# then it is possible to get duplicate catalogid where
# one catalogid is from query_gaia_dr3 and other is from
# query_twomass_psc. This will be detected at the time of
# creation of the unique index on catalogid
# in the temporary table.
# Hence, the carton owner should remove such duplicates in the
# manual carton input fits file.

query_gaia_dr3 = \
(query_common
.join(CatalogToGaia_DR3)
Expand Down Expand Up @@ -422,6 +438,9 @@ def build_query(self, version_id, query_region=None):

query = None

# Below variable 'query' is a UNION of queries.
# The operator | is used to construct a UNION of queries.

if (is_gaia_dr3 is True):
if (query is None):
query = query_gaia_dr3
Expand Down Expand Up @@ -459,7 +478,8 @@ def build_query(self, version_id, query_region=None):
query = query | query_twomass_psc

if (query is None):
# At least one of the four boolean variables above
# At least one of the boolean variables above
# (e.g. is_gaia_dr3, is_gaia_dr2 etc.)
# must be True, so we should not get here.
raise TargetSelectionError('error in get_file_carton(): ' +
'(is_gaia_dr3 is False) and ' +
Expand Down
Loading