Support psycopg 3.x #268
Merged
Support psycopg 3.x #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havok2063
reviewed
Sep 3, 2024
| @@ -30,14 +30,15 @@ content-type = "text/markdown" | |||
|
|
|||
| [project.optional-dependencies] | |||
| all = [ | |||
| "psycopg[binary]", | |||
There was a problem hiding this comment.
Should we retain support for psycopg <3? I think you can install 2.9 and 3+ at the same time. Not sure if we need to, but I want to make sure we don't break any existing usage of sdssdb.
There was a problem hiding this comment.
Good point, I had not thought of that. According to this SQLA 2.x has native support so maybe that's something we can ensure we test when we update sdssdb to support it.
havok2063
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports using
psycopg3.x (the psycopg package) via thepeeweeplayhouse.psycopg3_extextension.Although not implemented in
peewee,psycopg3 supports asynchronous connections out of the box, which may be useful to implement in some form.This branch depends on #266 which should be merged first.