Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pad_fieldid function #46

Merged
merged 6 commits into from
Oct 18, 2023
Merged

update pad_fieldid function #46

merged 6 commits into from
Oct 18, 2023

Conversation

Sean-Morrison
Copy link
Contributor

Updates to pad_fieldid function to allow for wildcard and string fieldids

Updates to pad_fieldid function to allow for wildcard and string fieldids
@Sean-Morrison Sean-Morrison self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (022e942) 61.90% compared to head (eb61d0c) 64.89%.
Report is 2 commits behind head on main.

❗ Current head eb61d0c differs from pull request most recent head 6c7e32a. Consider uploading reports for the commit 6c7e32a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   61.90%   64.89%   +2.99%     
==========================================
  Files          11       11              
  Lines        1323     1490     +167     
  Branches      270      338      +68     
==========================================
+ Hits          819      967     +148     
- Misses        403      408       +5     
- Partials      101      115      +14     
Files Coverage Δ
python/sdss_access/path/path.py 77.50% <50.00%> (+3.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for updating / adding the test.

@havok2063 havok2063 merged commit 13320c7 into main Oct 18, 2023
4 checks passed
@havok2063 havok2063 deleted the boss branch March 8, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants