Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pubsub module from GORT and add tests #10

Merged
merged 9 commits into from
Dec 21, 2024
Merged

Conversation

albireox
Copy link
Member

Mainly copied the pubsub module from lvmgort with a few changes to the exchange name and such. Added some tests.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 88.53503% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.0%. Comparing base (728c47f) to head (de453ff).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/lvmopstools/pubsub.py 88.3% 5 Missing and 13 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #10     +/-   ##
=======================================
- Coverage   91.8%   91.0%   -0.7%     
=======================================
  Files         10      11      +1     
  Lines        544     698    +154     
  Branches      73      91     +18     
=======================================
+ Hits         499     635    +136     
- Misses        22      27      +5     
- Partials      23      36     +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albireox albireox merged commit 9cebf08 into main Dec 21, 2024
10 checks passed
@albireox albireox deleted the albireox-pubsub branch December 21, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant