Add get_state_names() to ActorState enum

This should fix an issue in which Python 3.10
does not provide a name for states with more
than one flag set.

src/lvmopstools/actor.py

@@ -97,6 +97,11 @@ class ActorState(enum.Flag):
     NOT_READY = TROUBLESHOOTING | TROUBLESHOOT_FAILED | RESTARTING
     SKIP_CHECK = CHECKING | TROUBLESHOOTING | RESTARTING
 
+    def get_state_names(self):
+        """Returns the state names that are set."""
+
+        return [state.name for state in self.__class__ if self & state]
+
 
 @dataclass
 class ErrorData:
@@ -140,7 +145,7 @@ async def actor_state(command: Command[LVMActor], *args, **kwargs):
 
     state = command.actor.state
     code = state.value
-    flags = state.name.split("|")
+    flags = state.get_state_names()
 
     if (model := command.actor.model) is not None:
         state_kw = model["state"]
@@ -280,7 +285,7 @@ def update_state(
                 "d",
                 state={
                     "code": self.state.value,
-                    "flags": self.state.name.split("|"),
+                    "flags": self.state.get_state_names(),
                     "error": error_data,
                 },
                 internal=internal,

tests/test_actor.py

@@ -82,7 +82,11 @@ def test_get_error_codes_not_valid():
 
 @pytest.mark.parametrize(
     "side_effect",
-    [ValueError("Test error"), CheckError("Test error", ErrorCodes.UNKNOWN)],
+    [
+        ValueError("Test error"),
+        CheckError("Test error", ErrorCodes.UNKNOWN),
+        CheckError("Test error", 9999),
+    ],
 )
 async def test_actor_check_fails(lvm_actor: LVMActor, mocker, side_effect: Exception):
     lvm_actor._check_internal = mocker.AsyncMock(side_effect=side_effect)
@@ -101,6 +105,8 @@ async def test_actor_check_fails(lvm_actor: LVMActor, mocker, side_effect: Excep
     assert replies[2]["state"]["code"] & ActorState.TROUBLESHOOTING.value
     assert replies[3]["state"]["code"] & ActorState.READY.value
 
+    assert replies[1]["state"]["flags"] == ["RUNNING", "READY"]
+
 
 async def test_actor_restart(lvm_actor: LVMActor, mocker: MockerFixture):
     lvm_actor.restart_after = 2