-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0 #36
Merged
Merged
Version 1.0 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
========================================
+ Coverage 61.9% 93.5% +31.7%
========================================
Files 21 16 -5
Lines 917 488 -429
Branches 180 84 -96
========================================
- Hits 567 456 -111
+ Misses 318 27 -291
+ Partials 32 5 -27 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full rewrite, mostly to simplify the code and take advantage of some additional features in the DLI REST API.
The main difference in this version is that the code has been significantly simplify by assumming that one instance of the
lvmnps
actor can only control one NPS. This means that all theswitch
flags and parameters are deprecated.The code has been simplified. It still follows the approach of a core, abstract
NPSClient
class with multiple implementations for different switches, but some options that were not used have been removed.The DLI client now allows to command functions.