Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0 #36

Merged
merged 36 commits into from
Nov 24, 2023
Merged

Version 1.0 #36

merged 36 commits into from
Nov 24, 2023

Conversation

albireox
Copy link
Member

Full rewrite, mostly to simplify the code and take advantage of some additional features in the DLI REST API.

  • The main difference in this version is that the code has been significantly simplify by assumming that one instance of the lvmnps actor can only control one NPS. This means that all the switch flags and parameters are deprecated.

  • The code has been simplified. It still follows the approach of a core, abstract NPSClient class with multiple implementations for different switches, but some options that were not used have been removed.

  • The DLI client now allows to command functions.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (5935811) 61.9% compared to head (9e1a136) 93.5%.

❗ Current head 9e1a136 differs from pull request most recent head 8a27932. Consider uploading reports for the commit 8a27932 to get more accurate results

Files Patch % Lines
src/lvmnps/actor/actor.py 90.5% 2 Missing and 2 partials ⚠️
src/lvmnps/actor/commands/onoff.py 94.0% 1 Missing and 1 partial ⚠️
src/lvmnps/tools.py 95.3% 1 Missing and 1 partial ⚠️
src/lvmnps/__main__.py 0.0% 1 Missing ⚠️
src/lvmnps/actor/commands/refresh.py 92.4% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #36      +/-   ##
========================================
+ Coverage   61.9%   93.5%   +31.7%     
========================================
  Files         21      16       -5     
  Lines        917     488     -429     
  Branches     180      84      -96     
========================================
- Hits         567     456     -111     
+ Misses       318      27     -291     
+ Partials      32       5      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albireox albireox merged commit db55c3a into main Nov 24, 2023
6 checks passed
@albireox albireox deleted the albireox-1.0 branch November 24, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant