Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heartbeat command #28

Merged
merged 9 commits into from
Dec 25, 2024
Merged

Add heartbeat command #28

merged 9 commits into from
Dec 25, 2024

Conversation

albireox
Copy link
Member

Removed the automatic setting of the heartbeat variable. Added a heartbeat command that will be triggered by a heartbeat middleware.

@albireox albireox requested a review from mmingyeong as a code owner December 20, 2024 23:01
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.6%. Comparing base (81a4870) to head (160fa54).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/lvmecp/plc.py 20.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #28     +/-   ##
=======================================
+ Coverage   62.3%   62.6%   +0.4%     
=======================================
  Files         19      20      +1     
  Lines        881     883      +2     
  Branches     132     132             
=======================================
+ Hits         548     552      +4     
+ Misses       277     275      -2     
  Partials      56      56             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albireox albireox merged commit 91bf52f into main Dec 25, 2024
3 of 5 checks passed
@albireox albireox deleted the albireox-heartbeat-command branch December 25, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant