Add is_engineering_mode_enabled() to retrieve status

python/lvmecp/actor/actor.py

@@ -104,16 +104,11 @@ async def emit_status(self, delay: float = 30.0):
 
     async def engineering_mode(
         self,
-        enable: bool | None = None,
+        enable: bool,
         timeout: float | None = None,
     ):
         """Sets or returns the engineering mode."""
 
-        is_enabled = self._engineering_mode
-
-        if enable is None:
-            return is_enabled
-
         # Kill current task if it exists.
         self._engineering_mode_task = await cancel_task(self._engineering_mode_task)
 
@@ -124,6 +119,11 @@ async def engineering_mode(
 
         self._engineering_mode = enable
 
+    def is_engineering_mode_enabled(self):
+        """Returns whether engineering mode is enabled."""
+
+        return self._engineering_mode
+
     async def _run_eng_mode(self, timeout: float | None = None):
         """Runs the engineering mode.
 

python/lvmecp/actor/commands/engineering.py

@@ -55,6 +55,4 @@ async def disable(command: ECPCommand):
 async def status(command: ECPCommand):
     """Returns the status of the engineering mode."""
 
-    status = await command.actor.engineering_mode()
-
-    return command.finish(engineering_mode=status)
+    return command.finish(engineering_mode=command.actor.is_engineering_mode_enabled())

tests/test_command_engineering_mode.py

@@ -41,12 +41,12 @@ async def test_command_engineering_mode_no_mock(actor: ECPActor):
     cmd = await actor.invoke_mock_command("engineering-mode enable --timeout 10")
     await cmd
 
-    assert await actor.engineering_mode() is True
+    assert actor.is_engineering_mode_enabled() is True
 
     cmd = await actor.invoke_mock_command("engineering-mode disable")
     await cmd
 
-    assert await actor.engineering_mode() is False
+    assert actor.is_engineering_mode_enabled() is False
 
 
 async def test_command_engineering_mode_timeouts(actor: ECPActor):
@@ -55,8 +55,8 @@ async def test_command_engineering_mode_timeouts(actor: ECPActor):
     cmd = await actor.invoke_mock_command("engineering-mode enable --timeout 0.2")
     await cmd
 
-    assert await actor.engineering_mode() is True
+    assert actor.is_engineering_mode_enabled() is True
 
     await asyncio.sleep(0.3)
 
-    assert await actor.engineering_mode() is False
+    assert actor.is_engineering_mode_enabled() is False