Dev/python cleanup #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python, it's normal to access attributes directly. If it every becomes necessary to wrap an attribute in a getter/setter, there are @decorators that will maintain backwards compatability.
The Arduino interface needs to be documented better, or at least mentioned. but I don't have enough information to do so myself. The documentation added in this commit also makes a few assumptions on the ranges of inputs, and their meaning. These should not be assumptions.
Simplify the drive_forward and drive_backward implementations. Note that the send_cmd() method already maps numbers to a short integer, so we don't need to do so ourselves. (Verify?) Also, the locomotion methods should make a note of the type of locomotion they implement.
Major: * align constants even though our beloved PEP8 forbids it. * Add optional timeout to drive_*_wheel commands so that they act the same as the drive_forward and drive_backward commands. Minor: * Add comments, examples, solve world hunger, etc., etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up module.
Add documentation and follow more "Pythonic" standards.