Restructures Admin Backend #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratham1729
reviewed
Nov 27, 2023
pratham1729
reviewed
Nov 27, 2023
|
check the kratos.go file in the config folder and make a function for admin URL as well, instead of hardcoding the admin URL everywhere |
|
we need to keep all the requests in json format, so change the request from forms to JSON format |
pratham1729
reviewed
Nov 28, 2023
Aryan51203
force-pushed
the
VettelMajor
branch
from
ef34674 to
008e54b
Compare
itsdarshankumar
requested changes
Dec 12, 2023
api/admin.go
Outdated
| data, _ := json.Marshal(t) | ||
| json.Unmarshal(data, &mappedJsonIdentity) | ||
|
|
||
| adminCreateIdentityBody := *client.NewAdminCreateIdentityBody( |
There was a problem hiding this comment.
move this to wrapper
api/admin.go
Outdated
| var mappedJsonIdentity map[string]interface{} | ||
|
|
||
| data, _ := json.Marshal(t) | ||
| json.Unmarshal(data, &mappedJsonIdentity) |
There was a problem hiding this comment.
error handling please
api/admin.go
Outdated
| log.ErrorLogger("Error while calling `AdminCreateIdentity`", err) | ||
| fmt.Fprintf(os.Stderr, "Full HTTP response: %v\n", r) | ||
| c.JSON(http.StatusInternalServerError, gin.H{ | ||
| "error": "INternal server error", |
There was a problem hiding this comment.
'N' shouldn't be capital
api/admin.go
Outdated
|
|
||
| var mappedJsonIdentity map[string]interface{} | ||
|
|
||
| data, _ := json.Marshal(t) |
api/admin.go
Outdated
| return | ||
| } | ||
|
|
||
| jsonString, _ := json.Marshal(getIdentity.Traits) |
api/admin.go
Outdated
| var identity admin.Identity | ||
|
|
||
| if err := json.Unmarshal(jsonString, &identity); err != nil { | ||
| fmt.Println(err) |
api/mfa.go
Outdated
| @@ -51,8 +53,11 @@ func HandlePostMFAFlow(c *gin.Context) { | |||
| }) | |||
| return | |||
| } | |||
| session_cookie, _ := c.Cookie("sdslabs_session") | |||
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.