Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(htsget): htsget minio connection #101

Merged
merged 3 commits into from
Aug 16, 2024
Merged

fix(htsget): htsget minio connection #101

merged 3 commits into from
Aug 16, 2024

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Aug 14, 2024

This PR affects bugs that prevented htsget from connecting to the minio s3 bucket:

  • fixed malformed URL when no trailing slash was present on the input enpoint
  • Fixed compose environment variables to connect htsget to s3 using the service identifier unless S3_LOCAL_URL is set
  • configure htsget to use path-style bucket by default

@cmdoret cmdoret requested a review from almutlue August 14, 2024 13:52
@cmdoret cmdoret self-assigned this Aug 14, 2024
@cmdoret cmdoret added the bug Something isn't working label Aug 14, 2024
@cmdoret cmdoret merged commit 3e4842f into main Aug 16, 2024
3 checks passed
@cmdoret cmdoret deleted the fix/htsget-minio branch October 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almutlue almutlue Awaiting requested review from almutlue

Assignees

@cmdoret cmdoret

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmdoret