allow persistent directory for tar1090-update #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when recreating the container via docker compose, changes in the docker image are lost. this means tar1090-update needs to download data again. especially when changes to container are made via automation, this can happen relatively often and it's desirable that the data are not required to be downloaded more than once change the directory for the tar1090 and tar1090-db git dirs and the aircraft.csv.gz file to TAR1090_UPDATE_DIR=/var/globe_history/tar1090-update this directory is already mounted on most installs and redownloads are avoided the Dockerfile places aircraft.csv.gz in TAR1090_INSTALL_DIR so it can be used in the unlikely event of /var/globe_history being mounted while UPDATE_TAR1090 is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when recreating the container via docker compose, changes in the docker image are lost. this means tar1090-update needs to download data again. especially when changes to container are made via automation, this can happen relatively often and it's desirable that the data are not required to be downloaded more than once
change the directory for the tar1090 and tar1090-db git dirs and the aircraft.csv.gz file to TAR1090_UPDATE_DIR=/var/globe_history/tar1090-update
this directory is already mounted on most installs and redownloads are avoided
the Dockerfile places aircraft.csv.gz in TAR1090_INSTALL_DIR so it can be used in the unlikely event of /var/globe_history being mounted while UPDATE_TAR1090 is false