Simplify startup and dependencies #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move startup scripts to /etc/s6-overlay/startup.d Create oneshot service named "startup" which executes all files in /etc/s6-overlay/startup.d in alphabetical order Remove various oneshot scripts from longrun service dependencies Add "startup" oneshot service to longrun service dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a whole dependency forest just to start a couple of startup scripts in order.
Additionally all the services also have a dependency on all the startup scripts.
This is unnecessary complex, simplify it:
Move startup scripts to /etc/s6-overlay/startup.d
Create oneshot service named "startup" which executes all files in
/etc/s6-overlay/startup.d in alphabetical order
Remove various oneshot scripts from longrun service dependencies
Add "startup" oneshot service to longrun service dependencies
The oneshot service to start all scripts in /etc/s6-overlay/startup.d could be included in the baseimage after some testing and if that's something sdr-enthusiasts is interested in.
The script was tested against an empty or non-existent directory as well and just exits 0 in that case.
If one of started scripts exits with an error, it will announce it and propagate the error.
This preserves the behaviour of the container startup being aborted in that case.