fixed race condition on the main map, added a test, normalized filepaths, handled windows rename issue #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrhlnd, thanks for the pull request. If you could do a couple of things, that would be great:
Your changes look good, and I'm confident we'll get them merged in, thanks. |
| c, ok := d.mutexes[collection] | ||
|
|
||
| d.maplock.RUnlock() |
There was a problem hiding this comment.
dropping the read lock and acquiring a write lock is a race condition. Inside the write lock you should check to see if the mutex has already been created, to avoid a second mutex being created.
|
Re-pushed with the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main map had a race condition. Made a minor test file for ya. Made the test pass on windows, which had issues with your rename. Also normalized the paths with the filepath package.