Fix manager #130
Merged
Fix manager #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
kimpaller
reviewed
Jan 8, 2025
nebula/manager.py
Outdated
| @@ -740,8 +740,7 @@ def _find_boot_files(self, folder): | |||
| res = [] | |||
| for file in files: | |||
| path = os.path.join(folder, file) | |||
| filesize = os.stat(path).st_size | |||
| if filesize <= 80: | |||
| if os.stat(path).st_size == 0: | |||
There was a problem hiding this comment.
How about the files that are not 0 bytes but are not valid, e.x files that are actually text just composed of "File Not Found" description. I believe this was set to 80 to address that specific issue.
There was a problem hiding this comment.
Oh right, thanks for pointing that out. I reverted the commit and will create another PR instead to further address the issue.
kimpaller
approved these changes
Jan 8, 2025
This reverts commit 3a401b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes checking of empty files.
This also fixes the wrong boot partition folder dumped into properties.yaml.