DeviceInstanceMapper: do not skip devices with inputDeviceError #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a bunch of non-pushbutton switches connected to some of my Lunatone DALI-2 MC pushbutton couplers. These devices unfortunately set the
"inputDeviceError"
bit whenever any of its inputs is closed/shorted for longer thanT_stuck
.The 62386-301:2017 says (Table 4, page 15) that this timer is up to 255s, which is definitely not enough for a door sensor. The same standard then says that such errors should be propagated to bit 0 in the
"instanceErrorByte"
, which python-dali does not query. However, my devices unfortunately also propagate this status into the"inputDeviceError"
, and that means that the initial discovery of instance numbers to instance types won't recognize these buttons at all.I was not able to find a reference in the standard whether any
"instanceError"
propagates to the"inputDeviceError"
, but even if this was an incorrect behavior, these devices exist, one can buy them, and presumably using them as a kind-of persistent contact inputs still makes sense; just to provide some data, I have:I think that both use cases make sense, and I would prefer python-dali to not skip over some input devices which actually work just fine.
Fixes: 0cfddb7