Fixup some code quality metric issues

commons-testing/src/main/java/be/sddevelopment/commons/testing/conventions/CodeConventions.java

@@ -88,7 +88,7 @@ private static GivenClassesConjunction constantClasses() {
 		return classes().that().areAnnotatedWith(Constants.class).and().areNotAnnotations();
 	}
 
-	static ArchCondition<? super JavaClass> notBeInstantiatable() {
+	static ArchCondition<JavaClass> notBeInstantiatable() {
 		return new ArchCondition<>("not be instantiatable") {
 			@Override
 			public void check(JavaClass item, ConditionEvents events) {

commons-testing/src/test/java/be/sddevelopment/commons/testing/ConventionsAdherenceTests.java

@@ -0,0 +1,36 @@
+/*-
+ * #%L
+ * commons
+ * %%
+ * Copyright (C) 2020 - 2024 SD Development
+ * %%
+ * Licensed under the EUPL, Version 1.1 or – as soon they will be
+ * approved by the European Commission - subsequent versions of the
+ * EUPL (the "Licence");
+ *
+ * You may not use this work except in compliance with the Licence.
+ * You may obtain a copy of the Licence at:
+ *
+ * http://ec.europa.eu/idabc/eupl5
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the Licence is distributed on an "AS IS" basis,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the Licence for the specific language governing permissions and
+ * limitations under the Licence.
+ * #L%
+ */
+
+package be.sddevelopment.commons.testing;
+
+import be.sddevelopment.commons.testing.conventions.CodeConventions;
+import com.tngtech.archunit.junit.AnalyzeClasses;
+
+@AnalyzeClasses(packages = "be.sddevelopment.commons.testing")
+public class ConventionsAdherenceTests implements CodeConventions {
+
+	/* This class can be empty, it is used to run the test of its parent interface
+	 * CodeConventions. This interface contains the tests for the code conventions,
+	 * and will execute them based on the {@code @AnalyzeClasses} annotation.
+	 */
+}

commons/src/test/java/be/sddevelopment/commons/ConventionsAdherenceTests.java

@@ -7,12 +7,12 @@
  * Licensed under the EUPL, Version 1.1 or – as soon they will be
  * approved by the European Commission - subsequent versions of the
  * EUPL (the "Licence");
- * 
+ *
  * You may not use this work except in compliance with the Licence.
  * You may obtain a copy of the Licence at:
- * 
+ *
  * http://ec.europa.eu/idabc/eupl5
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the Licence is distributed on an "AS IS" basis,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -29,4 +29,9 @@
 @AnalyzeClasses(packages = "be.sddevelopment.commons")
 public class ConventionsAdherenceTests implements CodeConventions {
 
+	/* This class can be empty, it is used to run the test of its parent interface
+	 * CodeConventions. This interface contains the tests for the code conventions,
+	 * and will execute them based on the {@code @AnalyzeClasses} annotation.
+	 */
+
 }

commons/src/test/java/be/sddevelopment/commons/access/AccessProtectionUtilsTest.java

@@ -24,7 +24,6 @@
 package be.sddevelopment.commons.access;
 
 import static be.sddevelopment.commons.testing.ReflectionAssertionUtils.assertPrivateMemberReflectionProtection;
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import be.sddevelopment.commons.testing.naming.ReplaceUnderscoredCamelCasing;
 import java.lang.reflect.Constructor;

pom.xml

@@ -257,6 +257,7 @@
         <configuration>
           <excludes>
             <exclude>be/sddevelopment/commons/constants/**/*.class</exclude>
+            <exclude>be/sddevelopment/commons/testing/conventions/**/*.class</exclude>
           </excludes>
         </configuration>
       </plugin>