Sonar indicated issues

sddevelopment-be · Sep 22, 2024 · 9df532d · 9df532d
1 parent 6fbc0de
commit 9df532d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/commons-testing/src/main/java/be/sddevelopment/commons/testing/ReflectionAssertionUtils.java b/commons-testing/src/main/java/be/sddevelopment/commons/testing/ReflectionAssertionUtils.java
@@ -54,11 +54,10 @@ public final class ReflectionAssertionUtils {
 			"Utility classes should not have a public or default constructor";
 
 	private ReflectionAssertionUtils() {
-		throw new UnsupportedOperationException("Utility classes should not have a public or default constructor");
+		throw new UnsupportedOperationException(PROHIBITED_CONSTRUCTOR_ACCESS);
 	}
 
-	public static void assertPrivateMemberReflectionProtection(
-			@SuppressWarnings("rawtypes") final Constructor constructor) {
+	public static void assertPrivateMemberReflectionProtection(final Constructor<?> constructor) {
 		constructor.setAccessible(true);
 
 		assertThatThrownBy(constructor::newInstance, unprotectedConstructorError(constructor))
@@ -68,12 +67,12 @@ public static void assertPrivateMemberReflectionProtection(
 	}
 
 	public static void assertPrivateMember(
-			@SuppressWarnings("rawtypes") final Constructor constructor) {
+			@SuppressWarnings("rawtypes") final Constructor<?> constructor) {
 		assertThatThrownBy(constructor::newInstance, unprotectedConstructorError(constructor))
 				.isInstanceOfAny(InvocationTargetException.class, IllegalAccessException.class);
 	}
 
-	private static String unprotectedConstructorError(final Constructor constructor) {
+	private static String unprotectedConstructorError(final Constructor<?> constructor) {
 		return format("Constructor %s is expected to be protected from illegal access", constructor);
 	}
 }
diff --git a/...-testing/src/test/java/be/sddevelopment/commons/testing/ReflectionAssertionUtilsTest.java b/...-testing/src/test/java/be/sddevelopment/commons/testing/ReflectionAssertionUtilsTest.java
@@ -119,6 +119,7 @@ private ClassWithPrivateConstructor() {
 
 	static final class ClassWithPublicConstructor {
 		public ClassWithPublicConstructor() {
+			// Intentionally left empty to test the assertion
 		}
 	}
 

diff --git a/commons/src/test/java/be/sddevelopment/commons/validation/FallibleTest.java b/commons/src/test/java/be/sddevelopment/commons/validation/FallibleTest.java
@@ -44,7 +44,7 @@
 @DisplayNameGeneration(ReplaceUnderscoredCamelCasing.class)
 class FallibleTest {
 
-	public final List<String> NAUGHTY_WORDS = singletonList("string");
+	public static final List<String> NAUGHTY_WORDS = singletonList("string");
 	public static final String NAUGHTY_ERROR = "Your word seems to contain a naughty bit [%s]";
 
 	static class ConsumerServiceStub<T> {
-Original file line number
+Diff line change
@@ Expand Up / @@ -119,6 +119,7 @@ private ClassWithPrivateConstructor() { @@
     	static final class ClassWithPublicConstructor {
     		public ClassWithPublicConstructor() {
+    			// Intentionally left empty to test the assertion
     		}
     	}
@@ Expand Down @@