feat: wallet connectivity improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more logging persist changes to peer_manager in the watch updates to config files
hansieodendaal
force-pushed
the
ho_wallet_connectivity_2
branch
from
946e864 to
2f404b6
Compare
Closed
sdbondi
reviewed
Nov 7, 2024
base_layer/p2p/src/config.rs
Outdated
Comment on lines
106
to
107
| /// If set to `Private`, the node will not be used as a public relay | ||
| /// (Base node default: `Auto`, Wallet default: `Private`) |
There was a problem hiding this comment.
Suggested change
| /// If set to `Private`, the node will not be used as a public relay | |
| /// (Base node default: `Auto`, Wallet default: `Private`) | |
| /// If set to `Private`, the node assume it has no public address and will try to establish a relay connection as soon as possible. `Auto` will use auto NAT to try determine this automatically. | |
| /// (Base node default: `Auto`, Wallet default: `Private`) |
sdbondi
reviewed
Nov 7, 2024
sdbondi
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
more logging
persist changes to peer_manager in the watch
updates to config files
simplify BaseNodePeerManager
Motivation and Context
How Has This Been Tested?