Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Input level calibration #525

Merged
merged 11 commits into from
Nov 17, 2024
Merged

[FEATURE] Input level calibration #525

merged 11 commits into from
Nov 17, 2024

Conversation

sdatkinson
Copy link
Owner

@sdatkinson sdatkinson commented Nov 15, 2024 •
edited
Loading

image

Description

  • Integrate controls for setting the input calibration level of the plugin input
  • Activate input calibration (default off--better to have the same behavior as before than to have it automatically change the sound and maybe not be correct for the use case in the signal chain.)

Resolves #294.

PR Checklist

  • Does the VST3 plugin pass all of the unit tests in the VST3PluginTestHost? (Download it as part of the VST3 SDK here.)
    • Windows
    • macOS
  • [Y] Does your PR add, remove, or rename any plugin parameters?
    • [N] If yes, then have you ensured that older versions of the plug-in load correctly? (Usually, this means writing a new legacy unserialization function like _UnserializeStateLegacy_0_7_9.)

@sdatkinson
Rearrange about info
6a351aa
@sdatkinson
Define parameters for input calibration
7bb60f5
@sdatkinson
No click through ModelInfoControl--just use the 'close' button in the…
7dc3565 
… corner
@sdatkinson
Settings control: Clean up OnAttached() and set rect for background i…
523d6a2 
…mmediately
@sdatkinson
Input calibration controls
628ec60
@sdatkinson
Input calibration controls
7e13e98
@sdatkinson
Input calibration
f2364e9 
* Disable both the switch and knob when model doesn't have input calibration metadata
* Display I/O calibration levels in model info
* Add tooltip to input calibraiton knob.
* Don't disable mouse events when input calibraiton controls are disabled.
@sdatkinson
Set disable state correctly on UI open for input calibration controls
e9e0a5c
@sdatkinson
Input level as text control, still needs cleaning up
f357a15
@sdatkinson
Improve input level graphics, still iffy layout
d80342c
@sdatkinson
Merge branch 'main' into 294-input-level
a69f8d3
@sdatkinson sdatkinson changed the title [FEATURE, BREAKING] Input level calibration [FEATURE] Input level calibration Nov 16, 2024
@sdatkinson
Copy link
Owner Author

I'm going to put the backward-compatible unserialization for another PR; this one is already dauntingly big.

That'll let me help out #494 as well.

This was referenced Nov 16, 2024
Closed
Closed
@sdatkinson sdatkinson marked this pull request as ready for review November 17, 2024 01:19
@sdatkinson sdatkinson merged commit 420f438 into main Nov 17, 2024
2 checks passed
@sdatkinson sdatkinson deleted the 294-input-level branch November 17, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@sdatkinson