Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct .entitlements files #250

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

olilarkin
Copy link
Contributor

For some reason there are three .entitlements files in the NeuralAmpModeler-macOS.xcodeproj

This might be something todo with #152 or #215

  • Remove the wrong CODE_SIGN_ENTITLEMENTS entries & files
  • Correct an incorrect PRODUCT_BUNDLE_IDENTIFIER
  • add com.apple.security.files.downloads.read-write, so sandboxed app can access downloads folder
  • remove group.io.github.iplug2 appgroup

Copy link
Owner

@sdatkinson sdatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -4299,7 +4297,7 @@
"$(APP_FRAMEWORKS)",
"$(inherited)",
);
PRODUCT_BUNDLE_IDENTIFIER = "com.StevenAtkinson.app.--BINARY-NAME-2";
PRODUCT_BUNDLE_IDENTIFIER = "com.StevenAtkinson.app.${BINARY_NAME}";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Sorry about that 😅

@sdatkinson sdatkinson merged commit ef13b10 into sdatkinson:main May 27, 2023
@olilarkin olilarkin deleted the fix-entitlements branch June 26, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants