Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Sign and notarise the releases. #185

Closed
colin-campbell opened this issue Apr 11, 2023 · 6 comments
Closed

[FEATURE] Sign and notarise the releases. #185

colin-campbell opened this issue Apr 11, 2023 · 6 comments
Labels
enhancement New feature or request priority:low Low priority issues

Comments

@colin-campbell
Copy link

I would be happy to sponsor a year's Apple developer subscription for the author to sign releases and have Apple Notarise the DMG to lower the barrier for take-up amongst non-technical users on Apple.

@colin-campbell colin-campbell added enhancement New feature or request priority:low Low priority issues unread This issue is new and hasn't been seen by the maintainers yet urgent:no labels Apr 11, 2023
@olilarkin
Copy link
Contributor

FWIW @sdatkinson I am working on new CI scripts for the iPlug2OOS repo which will do all the signing etc in the cloud

@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label Apr 12, 2023
@colin-campbell
Copy link
Author

Github actions can do it excellently with the existing script, I should think, or alternatively, there is a specific action for it.

@olilarkin
Copy link
Contributor

olilarkin commented Apr 12, 2023

nope. i wrote that script and it doesn't include code-signing. -> i mean the workflow requires some extra steps to deal with Apple Dev Certs in github secrets etc which are not in the iPlug2OOS version that NAMPlugin was created from originally

@colin-campbell
Copy link
Author

I understand. If you not are actively working on it, I'm happy also to contribute code there. Or on the port to Cmake that I saw was being worked on, if it is still active.

@olilarkin
Copy link
Contributor

oops duplicate -> #365 but this is really important

@sdatkinson
Copy link
Owner

Let's close this and continue w/ #365 to keep things deduped 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority issues
Projects
None yet
Development

No branches or pull requests

3 participants